ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > ervin wrote in kfileplacesview.cpp:863-866 > This duplicates code from the next if branch below... I wonder if before or > after that commit we shouldn't try to refactor that and remove some of the > code duplication around the delegate animation use? I still stand by that comment, I'd welcome a patch on top of that one to reduce that duplication please. > franckarrecot wrote in kfileplacesview.cpp:298 > I'm filling a list of persistant indexes with regular indexes that is why I > use the loop, if you have any other way comment it to me please :) That smells std::transform instead of the hand crafted loop at least. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent Cc: mwolff, #frameworks
