anthonyfieroni requested changes to this revision.
anthonyfieroni added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcompositejob.cpp:67
> + if (d->subjobs.removeAll(job) > 0) {
> + job->setParent(nullptr);
> + return true;
We don't want to be notified about this job too
job->disconnect(this);
> kcompositejob.cpp:87
> Q_FOREACH (KJob *job, d->subjobs) {
> job->setParent(nullptr);
> }
Here same as line:68
> kcompositejob.cpp:99
> setErrorText(job->errorText());
> emitResult();
> }
I agree that we set first error but we shouldn't emit if job queue isn't empty.
> kcompositejob.cpp:102
>
> removeSubjob(job);
> }
Here after remove last job it should emit no?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9004
To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni
