dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
Looks good, but aren't there unittests missing for the non-editable combo case? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaure Cc: #frameworks