dfaure added a comment.
Well, if this QSet can be huge, then these conversions from QList and to QList are going to take a lot of CPU. Are you sure it wouldn't be much faster to do a linear search at append time, in exchange for saving all those temporary-containers conversions? This code looks VERY slow to me, due to the large amount of temporary memory allocations, and linear container conversions. IMHO the method that returns a List forces us to keep using a List as the data structure. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9318 To: anthonyfieroni, leinir, #frameworks Cc: dfaure, broulik
