mlaurent added a comment.
Missing all patch... please see "https://community.kde.org/Infrastructure/Phabricator"; "Step 2: Updating your diff. After you upload the code the reviewer will take a look and give you some comments. If you get a thumbs up, you can skip this step. But often you will get a review like "looks good, we can take it if you fix problems x, y, z." After you make your changes, you can add an extra commit to the git branch. $ git add -u $ git commit $ arc diff " REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
