elvisangelaccio added inline comments. INLINE COMMENTS
> michaelh wrote in ktooltipwidget.cpp:155 > > Are you saying that you don't want to correct it at the second place, just > > because tests did not reveal a bug? > > Yes, but it is rather like this: Due to my lack of my experience I don't > introduce chances which I can't test or see the results of. More a question > of 'dare' than 'want' :) > > As margin is not included in sizeHint() I think it is correct to do > > +margin when tooltip is displayed right of rect and > -margin when displayed left of rect. > > Both would result in a margin-wide space between rect and tooltip which is > necessary to dismiss the tooltip. > @elvisangelaccio: What do you think? Sorry but I'm not the original author of this code, so I don't really know what's going on here. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham Cc: cfeck