cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:45
>  
> -set(KAUTH_HELPER_INSTALL_DIR "${KDE_INSTALL_LIBEXECDIR}/kauth")
> +option(KAUTH_HELPER_INSTALL_DIR "Set directory for kauth helper tool" 
> "${KDE_INSTALL_LIBEXECDIR}/kauth")
>  

the 3rd parameter is a bool. This change won't do what you expect.

(https://cmake.org/cmake/help/v3.0/command/option.html)

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10075

To: knauss, #frameworks, skelly
Cc: cgiboudeaux, #frameworks

Reply via email to