jtamate added inline comments. INLINE COMMENTS
> dfaure wrote in urlutil_p.h:69 > s/S/s/ twice > > You could also just use adjustedCurrentUrl.path(QUrl::StripTrailingSlash), no? > Then you wouldn't have to deal with the fact that the path might end with a > slash > (and it would also cover the case where it ends with two or more consecutive > slashes....) It is already done (it's a pity that this can't be seen creating the patch using the web): const QUrl adjustedLastUrl = lastUrl.adjusted(QUrl::StripTrailingSlash); const QUrl adjustedCurrentUrl = currentUrl.adjusted(QUrl::StripTrailingSlash); but in the case of the new test, the values are: "/d" and "/" from the originals: "file:///d" and "file:///" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10071 To: jtamate, #frameworks, dfaure Cc: ngraham
