elvisangelaccio added a comment.
+1, looks good to me. INLINE COMMENTS > michaelh wrote in filemetadataprovider.cpp:323 > Is it guaranteed, that this is emitted before IndexedDataRetriever job is > finished? I don't think so, because `IndexedDataRetriever::start()` does not block. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D10113 To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks Cc: dhaumann