aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. aacid requested review of this revision.
REVISION SUMMARY I'm a bit unconvinced, wihtout it we get a warning if we enable -Wzero-as-null-pointer-constant but using Z_NULL seems to be more "what the library wants" If we don't want this, this would be a reason against enabling -Wzero-as-null-pointer-constant for all the frameworks as i've suggested in the other review REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D10168 AFFECTED FILES src/kgzipfilter.cpp src/kzip.cpp To: aacid Cc: #frameworks, michaelh