ossi added inline comments. INLINE COMMENTS
> chinmoyr wrote in sharefd_p.h:60 > I just feel like the job of SocketAddress should be to create the address > structure and not perform any file operation. Removal of the socket file > should be handled by file ioslave or FdReceiver. that's a valid concern, but doing that belongs into a separate patch which does the complementary change (as far as necessary) atomically, and explains it properly in the commit message. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks Cc: ossi, thiago, dfaure, michaelh, ngraham