broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision.
REVISION SUMMARY Indicate state, not the action it will have. WHen the password field is empty it feels like the password will be shown once I start typing. Also, Dolphin does it this way for the "show hidden files" action. TEST PLAN Empty field F5697019: Screenshot_20180207_152108.png <https://phabricator.kde.org/F5697019> F5697017: Screenshot_20180207_151725.png <https://phabricator.kde.org/F5697017> F5697018: Screenshot_20180207_151729.png <https://phabricator.kde.org/F5697018> REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10362 AFFECTED FILES src/declarativeimports/plasmacomponents/qml/TextField.qml To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
