dfaure added a comment.
Looks good, but this means you can also remove the Q_PRIVATE_SLOT declaration for those slots defined in the private class (slotConnected, _k_foo etc.) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff, dfaure Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh