ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, markg, elvisangelaccio. Restricted Application added a project: Frameworks. ngraham requested review of this revision.
REVISION SUMMARY My patch D10314 <https://phabricator.kde.org/D10314> was insufficiently tested (sorry about that!) and introduced an "Ambiguous Shortcut" warning, because "show/hide inline preview" was already bound to F11. This patch solves that issue by changing the shortcut to F12. F11 was never appropriate for it, since F11 was used for something different in Dolphin anyway. DOlphin doesn't currently have a shortcut for "show hide inline previews", so there's nothing to be consistent with. I used F12 in the file dialogs since it's unused there and in Dolphin, too, so we could add it there if we really wanted to. TEST PLAN Tested with Kate. F11 toggles the aside preview, and F12 toggles the inline preview, like they should. No more conflicts REPOSITORY R241 KIO BRANCH solve-file-dialog-ambiguous-shortcut-issue (branched from master) REVISION DETAIL https://phabricator.kde.org/D10617 AFFECTED FILES src/filewidgets/kdiroperator.cpp src/filewidgets/kfilewidget.cpp To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio Cc: michaelh
