dfaure added inline comments.

INLINE COMMENTS

> monitorcommand.cpp:53
> +    while (!m_dbusInterface->isValid()) {
> +        QThread::msleep(50);
> +        m_dbusInterface->disconnect();

Hmm, why not just use QDbusServiceWatcher's signals, to connect to 
serviceRegistered, if the service isn't available when we start?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10578

To: michaelh, dfaure, alexeymin
Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, 
nicolasfella

Reply via email to