kossebau created this revision. kossebau added reviewers: Frameworks, Build System, apol. Restricted Application added a project: Frameworks. kossebau requested review of this revision.
REVISION SUMMARY automoc by itself can only detect metadata files referenced by direct usage of the Q_PLUGIN_METADATA macro. It does not do any C++ preprocessor evaluation. Instead it needs to be helped with regexp-based filter rules for detecting any names of files used as additional moc input. See docs for AUTOMOC_DEPEND_FILTERS for further details. In the near future all the boilerplate code should be replaced with a yet to be designed ECM macro. For now explicit code is used to collect use cases for the macro and still to fix the issue already. TEST PLAN Changing a JSON file (or for those generated from .desktop files changing that one) and running make results in the related *.moc file being regenerated and the related object file being recompiled. qtplugininfo shows that the created plugin binary has up-to-date JSON content. REPOSITORY R290 KPackage BRANCH useCMAKE_AUTOMOC_DEPEND_FILTERS REVISION DETAIL https://phabricator.kde.org/D10733 AFFECTED FILES CMakeLists.txt KF5PackageConfig.cmake.in To: kossebau, #frameworks, #build_system, apol Cc: michaelh