dfaure added inline comments. INLINE COMMENTS
> chinmoyr wrote in slavebase.cpp:147 > Now I feel stupid for doing this. Apart from that I am not even confident > about this change because it involves changes in KAuth (Obviously I am not > sure about them either). How about we drop this and the related revisions for > now and just delete the slave whenever there's authorization? If by delete you mean kill, I think you're right, it's probably simpler and safer, and this should happen rarely enough for this not to be a performance issue. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh