broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. broulik requested review of this revision.
REVISION SUMMARY I found this was called 350 times for me when opening the file dialog since for every paint pass it would needlessly call this for every place. It queries all mountpoints and does other expensive work. Instead, only do so when the bar would actually be shown. Ideally this would be cached somehow but this patch is a nice simple optimization already. TEST PLAN - Verified it is no longer called when opening file dialog - Free space bar still shows up fine when hovering a mounted USB device REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11088 AFFECTED FILES src/filewidgets/kfileplacesview.cpp To: broulik, #frameworks Cc: michaelh