rominf added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileitem.cpp:1116-1136
> Indeed this should be done in different way, about me
> 
>   std::uint64_t attr;
>   length = getxattr(fileName, attrName, &attr, sizeof attr);
>   if (length <= 0) {
>       return false;
>   }

I wish your code to work, but it doesn't. I took an inspiration from `attr`: 
http://git.savannah.nongnu.org/cgit/attr.git/tree/tools/getfattr.c#n235 and 
http://git.savannah.nongnu.org/cgit/attr.git/tree/tools/getfattr.c#n169.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks
Cc: anthonyfieroni, broulik, #frameworks, #dolphin, michaelh

Reply via email to