elvisangelaccio added a comment.

  Do you know why `qputenv()` doesn't work?

INLINE COMMENTS

> filemetadatawidgettest.cpp:41-44
> +#ifndef Q_OS_WIN
> +    setenv("LC_ALL", "en_US", 1);
> +#endif
> +    QLocale::setDefault(QLocale("en_US"));

Why both? `QLocale::setDefault()` seems to be enough here.

> filemetadatawidgettest.cpp:203-207
> +    valueWidget = m_widget->findChild<QLabel*>("albumArtist");
>      // FIXME: Make this pass
> -    // QCOMPARE( map->value("Album Artist:"), QLatin1String("Bill Laswell"));
> +    QEXPECT_FAIL("", "Common async properties not yet implemented", Abort);
> +    QVERIFY(valueWidget);
> +    QCOMPARE(valueWidget->text(), QLatin1String("Bill Laswell"));

This looks unrelated from the locale stuff? If yes please do it in another 
commit.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11238

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

Reply via email to