aleksejshilin added inline comments.

INLINE COMMENTS

> upowerdevice.cpp:98
> +         */
> +        return (uptype != 0 && uptype != 1 && uptype != 4);
>      default:

So you're changing from 'whitelist' to 'blacklist' behavior here. What will 
happen when another UPower device type is added by the upstream?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D11331

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

Reply via email to