ngraham added inline comments.
INLINE COMMENTS
> michaelh wrote in main.cpp:161
> To point this out. I'm **not** the maintainer of baloo. Maybe better remove
> this?
I think you sort of are Baloo's de facto maintainer (which is a good thing, and
you've earned the position)!
> main.cpp:65
> +
> +const auto commands = QVector<Command>{
> + Command{
Any reason not to use a std::vector instead?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11287
To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun,
nicolasfella, alexeymin
