cfeck requested changes to this revision.
cfeck added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> characterrangescjk.cpp:38
> +        if (i < length - 1 && c.isHighSurrogate() && 
> text.at(i+1).isLowSurrogate()) {
> +            c = c.surrogateToUcs4(c, text.at(++i));
> +        }

You need to use uint to store the full character. QChar is *not* a character, 
it is just one UTF-16 codeword.

Additionally, use the QChar::name(uint) static methods to operate on uint 
characters.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein, cfeck
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

Reply via email to