kossebau added inline comments.
INLINE COMMENTS
> netwm.cpp:2845-2847
> + const uint32_t data[5] = {
> + topology.top, topology.bottom, topology.left, topology.right, 1
> + };
Seems clang (at least as of FreeBSD with -Wc++11-narrowing) does not like this
narrowing from the int topology properties to the uint32_t array one:
00:37:23 /usr/home/jenkins/workspace/Dependency Build Frameworks kf5-qt5
FreeBSDQt5.9/kwindowsystem/src/platforms/xcb/netwm.cpp:2846:13: error:
non-constant-expression cannot be narrowed from type 'int' to 'uint32_t' (aka
'unsigned int') in initializer list [-Wc++11-narrowing]
00:37:23 topology.top, topology.bottom, topology.left,
topology.right, 1
00:37:23 ^~~~~~~~~~~~
https://build.kde.org/view/CI%20Management/job/Dependency%20Build%20Frameworks%20kf5-qt5%20FreeBSDQt5.9/25/console
Should this be fixed with some casting?
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D11414
To: graesslin, #frameworks, #kwin, #plasma, davidedmundson
Cc: kossebau, michaelh, ngraham
