D11642: Fix the rcc binary package generation

Friedrich W . H . Kossebau Sat, 24 Mar 2018 05:39:46 -0700

kossebau added inline comments.

INLINE COMMENTS


> KF5PackageMacros.cmake:158
> -        include(${kpackagedir}/qrc.cmake)
> -        message(STATUS \"Generating: 
> ${KDE_INSTALL_FULL_DATADIR}/${install_dir}/${root}/${component}/contents.rcc\")
> -        execute_process(COMMAND ${KPACKAGE_RCC} ${kpkgqrc} --binary -o 
> ${KDE_INSTALL_FULL_DATADIR}/${install_dir}/${root}/${component}/contents.rcc 
> ERROR_VARIABLE errors RESULT_VARIABLE code)

This "Generating xyz" might be still good to have. Please consider picking this 
up with a

  COMMENT "Generating: ${xyz}"

added to `add_custom_command`, where ${xyz} gets a proper variable name :) and 
as content the relative path to the current bin dir, by some

  file(RELATIVE_PATH xyz ${CMAKE_CURRENT_BINARY_DIR} ${GENERATED_RRC_CONTENTS})

or possibly using directly without the xyz var `${component}-contents.rcc` in 
the COMMENT message.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11642

To: bshah, mart, davidedmundson, apol
Cc: kossebau, #frameworks, michaelh, ngraham

D11642: Fix the rcc binary package generation

Reply via email to