rominf added inline comments. INLINE COMMENTS
> dfaure wrote in file_unix.cpp:422 > Doesn't this need to be static, for the next line to be standards compliant? > Not 100% sure. No, it's enough for array length to be `constexpr`. > dfaure wrote in file_unix.cpp:431 > QVarLengthArray might be useful here to avoid an allocation every time TIL about `QVarLengthArray`. Thank you. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, markg, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham
