kossebau added inline comments. INLINE COMMENTS
> config-kioslave-file.h.cmake:14 > +/* Defined if system has extended file attributes support. */ > +#cmakedefine01 HAVE_SYS_XATTR_H While FindACL.cmake sets internally the cmake variable HAVE_SYS_XATTR_H, it is not part of the officially set variables (cmp. notes in header of that file) So more future-proof will be to do an explicit check_include_files(sys/xattr.h HAVE_SYS_XATTR_H) in src/ioslaves/file/CMakeLists.txt instead of reyling on an undocumented side-effect of `find_package(ACL)`. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11716 To: rominf, #dolphin, kossebau, dfaure Cc: #frameworks, michaelh, ngraham