sitter added subscribers: dfaure, sitter. sitter added a comment.
@cgiboudeaux @dfaure I am almost entirely certain this broke building of ki18n itself when *it* contains translations. Neon packs translations into git builds, so here's the failure: https://build.neon.kde.org/job/xenial_unstable_kde_ki18n_bin_amd64/135/consoleText At a glance I'd say the change of `include(cmake/KF5I18NMacros.cmake)` to include `KI18n_BINARY_DIR` is to blame. Latter being the installation target directory it'd not be available at build time. This is gonna cause trouble major trouble for the next release. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux Cc: sitter, dfaure, #build_system, #frameworks, michaelh, ngraham
