elvisangelaccio added a comment.
+1 from me, other than the inline comment. INLINE COMMENTS > kfileitemactions.cpp:654 > + // Always show the top app inline > + QAction *act = d->createAppAction(offers.takeFirst(), menu); > + menu->addAction(act); Please use `true` rather than `menu` as 2nd argument REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, abetts, michaelh, ngraham
