astippich marked 3 inline comments as done. astippich added a comment.
In D10803#237133 <https://phabricator.kde.org/D10803#237133>, @michaelh wrote: > Except for the white space stuff I'm still fine with this. Oops, sorry, messed that up during rebase. INLINE COMMENTS > michaelh wrote in taglibextractor.cpp:304 > Nitpick: These comments aren't really informative. The tagname is explicit > enough. > I don't mind if you leave them in. You're right, I copied them from MP3s, but they make no sense for APE and OGG tags REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin
