michaelh added a comment.
This part of baloo is still unknown territory to me. Please be patient until I understood what is going on here. If you want to, ignore my inline comments. Then this file will violate the coding style rules at least consistently. INLINE COMMENTS > term.cpp:121 > + > + if (lhs.operation() == op) > + d->m_subTerms << lhs.subTerms(); <Coding style>Please use braces > term.cpp:129 > + else > + d->m_subTerms << rhs; > } </Coding style> REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin
