michaelh added inline comments. INLINE COMMENTS
> bruns wrote in databasesanitizer.cpp:333 > why not just make the removeDocument transaction above depend on dryRun? > removeDocument is expensive ... I did that before, but decided on `--dry-run` to simulate the process as close as possible. Also, compared to the time it takes to collect the data, removing the docs is completely neglectible. Committing to the database takes some seconds (on ~30000 entries) again. > bruns wrote in main.cpp:251 > make it depend on dry-run? Transaction complains (Q_ASSERT) when trying to remove a document on a readonly db or readonly transaction. Unless I guard `removeDocument` with an `if` (which I prefer not to) both have to be in readwrite mode. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
