bruns added inline comments.

INLINE COMMENTS

> advancedqueryparsertest.cpp:228
> +    const QString nofail;
> +    QString phrase;
> +    phrase = QStringLiteral("a AND b AND c AND d");

better use a different name, phrase has a special meaning, i.e. 
Baloo:EngineQuery:Phrase

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

Reply via email to