ngraham created this revision. ngraham added reviewers: VDG, Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision.
REVISION SUMMARY Right now, the Breeze icon for "Configure" is sub-optimal and nondescript, and has little visual connection to the idea of "configure me! Settings over here!" ["before" image goes here] There is already a better icon: a "two sliders" symbol that's currently used for configuring shortcuts, for some odd reason. Plasma instead deliberately uses this "two sliders" icon in many places (e.g. KRunner) and System Settings already uses "two sliders" iconography in its own icon. Also, the Breeze icon theme uses this icon for "configure" in GTK apps. It's very much a more appropriate icon. This patch uses the superior "two sliders" icon for "configure" in all contexts, and adjusts symlinks to maintain compatibility for places where the existing icon should be used. Also, the "configure shortcuts" icon changes to one that looks like a keyboard, which seems more appropriate given the feature itself. Possible further improvements in subsequent patches: - Improve the `input-keyboard` icon to look better at menu item size - Create a new icon for "configure toolbars" so we don't have to use the same "two sliders" icon for it TEST PLAN Deploy change, switch to Breeze Dark and then back to Breeze light again [images go here] Also tested with Breeze dark. REPOSITORY R266 Breeze Icons BRANCH more-consistent-configure-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12034 AFFECTED FILES icons-dark/actions/16/configure-shortcuts.svg icons-dark/actions/16/configure-toolbars.svg icons-dark/actions/16/configure.svg icons-dark/actions/16/configure_kile.svg icons-dark/actions/16/configure_project.svg icons-dark/actions/16/document-properties.svg icons-dark/actions/16/games-config-custom.svg icons-dark/actions/16/games-config-options.svg icons-dark/actions/16/gtk-preferences.svg icons-dark/actions/16/settings-configure.svg icons-dark/actions/16/step_object_Controller.svg icons-dark/actions/22/configure-shortcuts.svg icons-dark/actions/22/configure-toolbars.svg icons-dark/actions/22/configure.svg icons-dark/actions/22/configure_kile.svg icons-dark/actions/22/configure_project.svg icons-dark/actions/22/document-properties.svg icons-dark/actions/22/games-config-custom.svg icons-dark/actions/22/games-config-options.svg icons-dark/actions/22/gtk-preferences.svg icons-dark/actions/22/settings-configure.svg icons-dark/actions/22/step_object_Controller.svg icons-dark/actions/24/configure-shortcuts.svg icons-dark/actions/24/configure-toolbars.svg icons-dark/actions/24/configure.svg icons-dark/actions/24/document-properties.svg icons-dark/actions/24/games-config-custom.svg icons-dark/actions/24/games-config-options.svg icons-dark/actions/24/gtk-preferences.svg icons-dark/actions/24/settings-configure.svg icons-dark/actions/24/step_object_Controller.svg icons-dark/actions/32/configure-shortcuts.svg icons-dark/actions/32/configure.svg icons-dark/actions/32/document-properties.svg icons-dark/actions/32/games-config-custom.svg icons-dark/actions/32/games-config-options.svg icons-dark/actions/32/gtk-preferences.svg icons-dark/actions/32/settings-configure.svg icons-dark/actions/32/step_object_Controller.svg icons/actions/16/configure-shortcuts.svg icons/actions/16/configure-toolbars.svg icons/actions/16/configure.svg icons/actions/16/configure_kile.svg icons/actions/16/configure_project.svg icons/actions/16/document-properties.svg icons/actions/16/games-config-custom.svg icons/actions/16/games-config-options.svg icons/actions/16/gtk-preferences.svg icons/actions/16/settings-configure.svg icons/actions/16/step_object_Controller.svg icons/actions/22/configure-shortcuts.svg icons/actions/22/configure-toolbars.svg icons/actions/22/configure.svg icons/actions/22/configure_kile.svg icons/actions/22/configure_project.svg icons/actions/22/document-properties.svg icons/actions/22/games-config-custom.svg icons/actions/22/games-config-options.svg icons/actions/22/gtk-preferences.svg icons/actions/22/settings-configure.svg icons/actions/22/step_object_Controller.svg icons/actions/24/configure-shortcuts.svg icons/actions/24/configure-toolbars.svg icons/actions/24/configure.svg icons/actions/24/document-properties.svg icons/actions/24/games-config-custom.svg icons/actions/24/games-config-options.svg icons/actions/24/gtk-preferences.svg icons/actions/24/settings-configure.svg icons/actions/24/step_object_Controller.svg icons/actions/32/configure-shortcuts.svg icons/actions/32/configure.svg icons/actions/32/document-properties.svg icons/actions/32/games-config-custom.svg icons/actions/32/games-config-options.svg icons/actions/32/gtk-preferences.svg icons/actions/32/settings-configure.svg icons/actions/32/step_object_Controller.svg To: ngraham, #vdg, #plasma Cc: sharvey, #frameworks, michaelh, ngraham, bruns
