cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land.
I think it looks ok, no hard-coded colors, it seems to pass the basic static checks and we have a testcase. I would more like to have a test case in plain english, but the text just seems to be some random excert out of some old book, if google translate doesn't cheat me. REPOSITORY R216 Syntax Highlighting BRANCH add-logcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D11851 To: nibags, #framework_syntax_highlighting, cullmann Cc: cullmann, #frameworks, michaelh, genethomas, ngraham, bruns, vkrause, dhaumann