bruns added a subscriber: ngraham.
bruns added a comment.

  Looks good to me so far. If there are any issues, we can fix it up later IMHO.
  @ngraham as you reviewed other parts of the stack, can you do this one as 
well and accept?

INLINE COMMENTS

> databasesanitizer.cpp:257
> +            << sep << QStringLiteral("minor:0x%1").arg(minor(dev.id), 2, 16, 
> QLatin1Char('0'))
> +            << sep << QStringLiteral("indexed-items:%1").arg(dev.items);
> +

Hm how about `device:2052 [0:804]` or `device:2052 [0000:0804]`?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: ngraham, bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

Reply via email to