michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:166
> Why do you remove the private: here?

340: m_pimpl->m_transaction->removeDocument(info.id);
and more

> bruns wrote in databasesanitizer.cpp:343
> remove `sep`, use `QStringLiteral(" device: %1") instead

I'd like to keep it this way.

1. For consistency with `printList` and `printDevices`
2. I'm thinking in the opposite direction: Make `sep` global to easily change 
it to another value for all output or even add a `field-separator` 
getter/setter ('--separator') should the need arise. (in a separate patch, of 
course)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

Reply via email to