astippich added a comment.
This revision is only one possibility and is mainly there to start the discussion again on how to read the embedded picture data from e.g. audio files. Before this can land, Baloo has to be patched in order to cope with binary data. I think for Baloo there are two possibilities: (a) Put it in the database same as all other data or (b) ignore the binary data. In the latter case, applications would have to query the metadata separately in order to get the cover. For KFileMetaData I also see two possible implementation: Either in the taglibextractor, or in a completely new extractor that only reads the cover files (may be also useful for ebooks, but I don't know if such things exist there). If we agree on (a), I would opt to implement it in taglibextractor, if we chose (b) I think a new extractor makes sense such that applications would not have to read all the metadata again with the taglibextractor, but could specifically just read the picture data and get the rest from Baloo. Any other suggestions? Opinions? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns
