rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed.
The relation between the Preview and the Zoom slider is now a bit weird: You can override with the button, but once you move the slider the setting will be gone again. Also, when showing the dialog after closing it, the slider has preference over the button. In addition, even though the button says "enabled", users will wonder why no thumbnails are showing! Would it make sense to both: - Set the button state to "off" once the icons are too small, to make it clear that no previews are to be expected. - Disable the button, so manually toggling thumbnails only works if icons are big enough. Allowing to override even for small images would quickly lead to some kind of manual vs. automatic setting, but this would be even more confusing, so I'd rather not go in that direction. --- Also, before this goes in I'd like to see a similar patch for Dolphin. Not so much because of any implemention issue, but to get the (not quite uncontroversial) idea more exposure and to agree on a common vision for how thumbnails should behave everywhere. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns
