michaelh added inline comments.
INLINE COMMENTS
> CMakeLists.txt:4
> +set(KF5_VERSION "5.45.0") # handled by release scripts
> +#TODO: Verify it is handled by release scripts
> +
There is not indication that `baloo-widgets` is an Application. Yet it resides
in the `kde/applications` folder. Shouldn't it be moved into `frameworks`?
> CMakeLists.txt:36
> - ${CMAKE_BINARY_DIR}/src/naturalqueryparser
> - ${CMAKE_BINARY_DIR}/src/naturalqueryparser/baloo
> )
Leftovers from
https://cgit.kde.org/baloo-widgets.git/commit/?id=bf4faa2f830d290a6a0f4bac471baec54aeeeba5
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D12342
To: michaelh, #baloo, #dolphin, #frameworks
Cc: ashaposhnikov, astippich, spoorun
