dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good, but shouldn't you remove the Q_PRIVATE_SLOT declarations too?
They aren't used anymore, AFAICS.
INLINE COMMENTS
> kcoredirlister.cpp:2720
> + m_parent->connect(job, &KJob::infoMessage, m_parent,
> + [this](KJob *job,const QString &plain){ _k_slotInfoMessage(job,
> plain); });
> + m_parent->connect(job, QOverload<KJob*, ulong>::of(&KJob::percent),
> m_parent,
missing space after the first comma
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12228
To: jtamate, dfaure, #frameworks
Cc: michaelh, bruns
