elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > CMakeLists.txt:20 > > +find_package(KF5ConfigWidgets ${KF5_VERSION} REQUIRED) > Unfortunately we can't do this, kwidgetsaddons is tier1 and it cannot depend on another framework. We'll need to duplicate the relevant code from kconfigwidgets here. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, jnoack, #frameworks, michaelh, bruns