kossebau added a comment.
Good, seems we found agreed-on codebase :) Will brush over the API dox/code comments some more for a final thumb-up. Though after yesterday's prototyping of further dbusrunner plugins there is another thing where I might want to suggest some API change to be more future-proof (for some possible org.kde.krunner2): Currently the match requests have no support for being cancelled (not part of org.kde.krunner1 D-Bus API, and have not found something on the D-Bus layer how to signal the discarding the wait for a reply). The baloo dbusrunner simply only handles the latest request. which surely covers the typical use-case, still, it will continue to handle the latest request even if there is no longer interest in it. That approach might be an issue once there are more cpu-intensive dbusrunners, wasting resources (cpu/io) when not needed. To prepare for that it might make sense to turn `MatchReply` into a QObject, so it could get some signal `validChanged` or similar added once the backend supports discarding. While there currently already is a method to query the valid state, this is more a small convenience method given that right now it is under full control of the plugin developer when a MatchReply will get invalid, it will only happen on actions done via the API. But once the valid state can change by remote activitiy, a signal might be nice to have. Using a QObject would also allow to switch from the fragile `QVector<MatchReplyPrivate*> mActiveMatchReplies` to using a QPointer-based approach on the real MatchReply objects, which might be less fragile. What do you think? Would give this a separate try tonight, to get some idea. REPOSITORY R308 KRunner BRANCH kdbusrunnerlib2 REVISION DETAIL https://phabricator.kde.org/D10078 To: kossebau, broulik, davidedmundson Cc: bruns, michaelh, ngraham, #frameworks
