rkflx accepted this revision. rkflx added a comment.
Thanks for the patch. Pondered over the code, but could not find anything wrong. In D12544#254554 <https://phabricator.kde.org/D12544#254554>, @anemeth wrote: > I removed these checks: `&& !locationEdit->isVisible()` > I assume at one point the filename line edit was once set to hide/show on demand. Beineri originally implemented this in 0134fb3a5e50 <https://phabricator.kde.org/R446:0134fb3a5e507737d3ebc1ca8db7b0b1509d5e2c>, apparently. However, I don't understand why the check has a `!`. How could this ever work? At least in the latest KDE3 it is already broken. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns
