broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision.
REVISION SUMMARY Dialogs don't show up in task bar and also don't have window decoration so they're not meant to be minimized. However, they might still be minimized by external means, such as "Minimize All" plasmoid. In this case hide the dialog. Also, Qt restores a minimize state when showing again, rendering the dialog inaccessible. Before showing, always unset the minimized state using new Qt 5.10 API BUG: 381242 TEST PLAN - Opened system tray, checked the pin, Minimized All → Tray "is expanded" line disappeared - Opened system tray again → Dialog showed up just fine REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12876 AFFECTED FILES src/plasmaquick/dialog.cpp To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns
