sraizada updated this revision to Diff 34333. sraizada added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks.
Improved patch, closing brackets get eaten properly in all cases I tested. The only issue I found is that matching bracket highlighting can be off when entering 'incorrect' sequences of braces. Such as in this example, where the ) in the middle causes the second-to-last parenthesis to be matched with the first one. F5852484: highlighting.png <https://phabricator.kde.org/F5852484> The bracket-eating behaviour with such incorrect sequences is to simple ignore the incorrect ) in the middle - all four of the }})) at the end will get eaten. Out of the three other text editors I tested (IntelliJ, Sublime Text, and 'micro'), Sublime and micro also behave this way. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12295?vs=32417&id=34333 REVISION DETAIL https://phabricator.kde.org/D12295 AFFECTED FILES src/document/katedocument.cpp src/document/katedocument.h To: sraizada, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann, #frameworks
