ngraham added a comment.
In D12986#265633 <https://phabricator.kde.org/D12986#265633>, @rkflx wrote: > Just noticed that I based my suggestion on your screenshot, but missed to see that you changed the semantics compared to the original dialog: The trash won't be emptied completely after 7 days, but files older than 7 days will be deleted (based on the wording, you might want to check the code what's correct). > > Therefore I think we might have to keep the original wording and only add the label in front. F5860717: new version.png <https://phabricator.kde.org/F5860717> Still lookg good IMHO. In D12986#265633 <https://phabricator.kde.org/D12986#265633>, @rkflx wrote: > (Which is why I'm not too fond of changing every UI to the new style, because it is much work but creates little value.) The value is in standardizing on something. Plasma, System Settings KCMs, and Gwenview already use this style. Many others don't (see T8655 <https://phabricator.kde.org/T8655>). We had many VDG discussions on the subject, and decided to standardize on the labels-on-the-left style instead of the labels-on-top style. If we had decided to standarize on the other one, we would have simply had a different set of work converting Plasma, System Settings, and Gwenview. > What's your plan for landing this change, do you want to convert the other pages first? Yes, I'm doing all the other pages in D12571 <https://phabricator.kde.org/D12571> (which is WIP). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns
