davidedmundson added a comment.

  Please also fill in the testing done field.

INLINE COMMENTS

> tooltip.cpp:162
> +    dlg->SetAutoShowHide(m_autoShowHide);
> +    connect(dlg, &ToolTipDialog:.containtsMouseChanged, this, 
> &ToolTip::toolTipWindowContainsMouseChangedSlot);
>      dlg->setVisible(true);

doing a connect inside show() probably isn't what you want, you'll connect 
multiple times.

Also that signal name has a typo

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10305

To: lshoravi, #plasma, #plasma_accessibility, mart, aacid
Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, 
ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to