ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
`kiofilewidgets-kfileplacesmodeltest` still fails for me with this patch:
grep 'FAIL! : KFilePlacesModelTest' -A 3 Testing/Temporary/LastTest.log
FAIL! : KFilePlacesModelTest::testInitialState() Compared values are not
the same
Actual (m_places->rowCount()): 6
Expected (4) : 4
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(200)]
--
FAIL! : KFilePlacesModelTest::testInitialList() Compared lists have
different sizes.
Actual (placesUrls()) size: 6
Expected (urls) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(236)]
--
FAIL! : KFilePlacesModelTest::testReparse() Compared lists have different
sizes.
Actual (placesUrls()) size: 7
Expected (urls) size: 10
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(252)]
--
FAIL! : KFilePlacesModelTest::testMove() Compared lists have different
sizes.
Actual (placesUrls()) size: 7
Expected (urls) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(396)]
--
FAIL! : KFilePlacesModelTest::testPlacesLifecycle() Compared lists have
different sizes.
Actual (placesUrls()) size: 8
Expected (urls) size: 10
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(552)]
--
FAIL! : KFilePlacesModelTest::testDevicePlugging() Compared lists differ
at index 1.
Actual (placesUrls()): "/home/dev/Downloads"
Expected (urls): "/"
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(665)]
--
FAIL! : KFilePlacesModelTest::testDragAndDrop() Compared lists have
different sizes.
Actual (placesUrls()) size: 8
Expected (urls) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(472)]
FAIL! : KFilePlacesModelTest::testDeviceSetupTeardown() Compared values
are not the same
Actual (spy_changed.count()): 0
Expected (1) : 1
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(786)]
--
FAIL! : KFilePlacesModelTest::testRemoteUrls(Ftp) Compared lists have
different sizes.
Actual (placesUrls()) size: 9
Expected (urls) size: 10
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(853)]
--
FAIL! : KFilePlacesModelTest::testRemoteUrls(Samba) Compared lists differ
at index 2.
Actual (placesUrls()): "/home/dev/Downloads"
Expected (urls): "trash:/"
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(853)]
--
FAIL! : KFilePlacesModelTest::testRemoteUrls(Sftp) Compared lists have
different sizes.
Actual (placesUrls()) size: 11
Expected (urls) size: 10
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(853)]
--
FAIL! : KFilePlacesModelTest::testRemoteUrls(Fish) Compared lists have
different sizes.
Actual (placesUrls()) size: 12
Expected (urls) size: 10
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(853)]
--
FAIL! : KFilePlacesModelTest::testRemoteUrls(Webdav) Compared lists have
different sizes.
Actual (placesUrls()) size: 13
Expected (urls) size: 10
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(853)]
--
FAIL! : KFilePlacesModelTest::testIconRole(Places - Trash)
'index.data(KFilePlacesModel::IconNameRole).toString().startsWith(expectedIconName)'
returned FALSE. ()
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(999)]
FAIL! : KFilePlacesModelTest::testIconRole(Remote - Network)
'index.data(KFilePlacesModel::IconNameRole).toString().startsWith(expectedIconName)'
returned FALSE. ()
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(999)]
FAIL! : KFilePlacesModelTest::testIconRole(Devices - Nfs)
'index.data(KFilePlacesModel::IconNameRole).toString().startsWith(expectedIconName)'
returned FALSE. ()
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(999)]
FAIL! : KFilePlacesModelTest::testIconRole(Devices - foreign)
'index.data(KFilePlacesModel::IconNameRole).toString().startsWith(expectedIconName)'
returned FALSE. ()
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(999)]
FAIL! : KFilePlacesModelTest::testIconRole(Devices - Floppy)
'index.data(KFilePlacesModel::IconNameRole).toString().startsWith(expectedIconName)'
returned FALSE. ()
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(999)]
FAIL! : KFilePlacesModelTest::testIconRole(Devices - cdrom)
'index.data(KFilePlacesModel::IconNameRole).toString().startsWith(expectedIconName)'
returned FALSE. ()
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(999)]
FAIL! : KFilePlacesModelTest::testMoveFunction() Compared lists have
different sizes.
Actual (placesUrls()) size: 13
Expected (urls) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(1016)]
--
FAIL! : KFilePlacesModelTest::testPlaceGroupHidden() Compared lists have
different sizes.
Actual (placesUrls()) size: 13
Expected (urls) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(1090)]
--
FAIL! :
KFilePlacesModelTest::testPlaceGroupHiddenAndShownWithHiddenChild() Compared
lists have different sizes.
Actual (placesUrls()) size: 13
Expected (urls) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(1157)]
FAIL! : KFilePlacesModelTest::testPlaceGroupHiddenGroupIndexesIntegrity()
Compared values are not the same
Actual (m_places->groupIndexes(KFilePlacesModel::PlacesType).count()):
7
Expected (initialListOfPlaces().count()) :
3
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(1193)]
--
FAIL! : KFilePlacesModelTest::testPlaceGroupHiddenRole() Compared values
are not the same
Actual (index.data(KFilePlacesModel::GroupHiddenRole).toBool()): 1
Expected (false) : 0
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(1241)]
--
FAIL! : KFilePlacesModelTest::testFilterWithAlternativeApplicationName()
Compared lists have different sizes.
Actual (placesUrls()) size: 13
Expected (urls) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(1282)]
FAIL! : KFilePlacesModelTest::testSupportedSchemes() Compared lists have
different sizes.
Actual (placesUrls()) size: 17
Expected (initialListOfUrls()) size: 9
Loc: [/home/dev/repos/kio/autotests/kfileplacesmodeltest.cpp(1295)]
REVISION DETAIL
https://phabricator.kde.org/D13018
To: renatoo, ngraham
Cc: ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh,
bruns
