chinmoyr added inline comments. INLINE COMMENTS
> ossi wrote in fdreceiver.cpp:89 > i wonder whether that shouldn't come with an unconditional acceptConnection = > true; then - now the compilation succeeds, but it will fail to operate. given > that the whole feature is redundant with moving the socket to a safe place > (something you really should mention in the commit message), this seems like > a rather pointless limitation. I don't think making acceptConnection unconditionally true is a good idea. At least it will make this patch look horrible. Since getsocketopt conforms to posix, how about we check for __ unix __ , and posix compliance instead of __ linux __ and upon failure inform the user to install a posix compliant libc? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure, ossi Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns
